fix(note-editor): 'discard changes' incorrectly shown

[david-allison]

Purpose / Description

• Enable 'Don't Keep Activities'
• Edit Note
• Restore Activity
• Press Back
• 'Discard changes' incorrectly shown

This was caused as 'isFieldEdited' was incorrectly set

Broken in abcfcce

Fixes

• Fixes [BUG] Note Editor: 'Discard Changes' is shown if 'Don't Keep Activities' is activated #20059

Approach

isFieldEdited wasn't required if we were editing a note ... just check if the note's fields were changed

How Has This Been Tested?

Pixel 9 Pro, while editing

• Press back, with no changes => no dialog
• Press back, with changes => dialog
• Restore state, with no changes => no dialog
• Restore state, with changes => dialog

Learning

I want to refactor, but the screen is in maintenance mode

I didn't realize Kotlin made List == List work correctly (vs how java handled it).

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[lukstbit]

Ok.

I noticed that the tag changes are quietly discarded when restoring state:

Add/edit note -> Add a tag(no edits to fields) -> Send to background -> Restore screen -> Both Up and Back quietly close the editor with no dialog