Skip to content

fix(card-template-editor): update preview on card update #20098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
david-allison wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(card-template-editor): update preview on card update #20098

david-allison wants to merge 3 commits into from
+33 −8

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 13, 2026

Purpose / Description

When a user switched tabs in the template editor, the preview was not updated until the user typed

mainBinding.cardTemplateEditorPager.currentItem was the previous item inside doOnTabSelected

Fixes

Approach

Provide the correct ord to use

How Has This Been Tested?

Unit tested

Tested on an API 34 emulator: still worked after

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
test: fix: withTabletUi => withSplitPaneUi
6ddae67 
Broken in ef0613f
@david-allison
test: add validation/docs to selectTab
38d5fcb
@david-allison
fix(card-template-editor): update preview on card update
69d62c6 
`mainBinding.cardTemplateEditorPager.currentItem` was the previous
 item inside `doOnTabSelected`

Fixes 20097
@david-allison david-allison added Needs Review Review High Priority Request for high priority review labels Jan 13, 2026
BrayanDSO
BrayanDSO approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mah Nà Mah Nà

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

Needs Second Approval Has one approval, one more approval to merge Review High Priority Request for high priority review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tablet] Split card template editor not updating

2 participants

@david-allison @BrayanDSO