Fix #19225: refresh queue on note edit #20114
Conversation
what do you mean by that? |
|
When we edit the note, the card's mod time changes in the DB, but the scheduler's queue cache is still holding the old state. If we don't force refresh it, backend detects this mismatch (DB vs Cache) when we try to undo, it triggers the "card modified without updating queue" error. |
|
A test would make this easier to review |
Ayush-Patel-56
force-pushed
the
fix/19225-update-queue-on-note-edit
branch
from
0d22112 to
c13d904
Compare
|
Added the test case in ReviewerViewModelTest.kt. It verifies that the card state refreshes correctly after a template modification |
|
|
||
| @Before | ||
| fun setup() { | ||
| Dispatchers.setMain(StandardTestDispatcher()) |
There was a problem hiding this comment.
it was the boilerplate, but now base class already handles dispatcher setup, so it's removed now.
| val viewModel = ReviewerViewModel(handle) | ||
|
|
||
| advanceUntilIdle() | ||
| advanceRobolectricLooper() |
There was a problem hiding this comment.
I think it's not necessary as test uses a dispatcher that executes tasks immediately here.
| val notetype = note.notetype | ||
| val tmpls = notetype.templates | ||
| val tmpl = tmpls.first() | ||
| tmpl.qfmt = tmpl.qfmt + " Modified" |
There was a problem hiding this comment.
I have updated it as you suggested in next push.
| val newCard = viewModel.currentCard.await() | ||
| assertThat("Card should be refreshed (new instance)", newCard, not(sameInstance(card))) | ||
|
|
||
| viewModel.answerCard(Rating.GOOD) |
There was a problem hiding this comment.
You should probably be asserting something. If not: assertDoesNotThrow
There was a problem hiding this comment.
ok, i added assertDoesNotThrow.
| val card = viewModel.currentCard.await() | ||
| val note = card.note() | ||
| val notetype = note.notetype | ||
| val tmpls = notetype.templates | ||
| val tmpl = tmpls.first() | ||
| tmpl.qfmt = tmpl.qfmt + " Modified" |
There was a problem hiding this comment.
Very verbose, how about:
viewModel.currentCard.await().noteType().update {
templates.first().qfmt += " Modified"
}There was a problem hiding this comment.
Done, I used noteType().update approach which is much cleaner. I kept the initial val card = as I'm using it for not(sameInstance(card)) assertion later to check that card instance actually refreshes or not.
david-allison
added
the
Needs Author Reply
Ayush-Patel-56
force-pushed
the
fix/19225-update-queue-on-note-edit
branch
3 times, most recently
from
7bedddd to
2e9f1ea
Compare
Prevent 'card modified without updating queue' error by refreshing state when note text changes.
3 participants
Fix #19225: Refresh queue on note edit
Issue
Fixes #19225
Problem
Editing a note or template in the new reviewer desyncs the backend queue state. Attempting to Undo afterwards trigger a
bug: card modified without updating queueerror and messes up the review counts.Solution
Force updateCurrentCard() when
OpChanges.noteTextfires. This ensures we refresh the queue state from the backend whenever the card content changes.Testing
Added ReviewerViewModelTest which reproduces the issue by simulating a template edit and verifying that the
currentCardinstance is correctly refreshed from the backend.ReviewerViewModelTest.editing note template updates queue state preventing undo errorpasses.