fix js-api: return parsed object from nextTime/deckName

[krmanik]

Assisted-by: Claude Sonnet 5

Purpose / Description

Describe the problem or feature and motivation

ankiGetNextTime1-4 and ankiGetDeckName returned the raw response text instead of a parsed object, unlike the other API methods. The backend already emits valid JSON for these endpoints via ApiResult.String.

BREAKING CHANGE: these five methods now resolve to an object rather than a JSON string. Cards calling JSON.parse() on the result must drop it. API version bumped to 0.0.4.

Fixes

• Fixes ankiGetDeckName api returns JSON-encoded string instead of a parsed javascript object #21452

Approach

How does this change address the problem?

Removed the endpoint.includes("nextTime") || endpoint.includes("deckName") special case in handleRequest (js-api.js) so every endpoint goes through JSON.parse. Nothing else needed changing: AnkiDroidJsAPI.convertToByteArray(apiContract, string) already wraps these values in ApiResult.String, whose toString() builds a JSONObject — the same {"success": …, "value": …} envelope used by every other endpoint. The special case dates back to the sync-to-async conversion (#14564) and had no counterpart on the backend.

CURRENT_JS_API_VERSION bumped to 0.0.4 (MINIMUM_JS_API_VERSION left at 0.0.3), and the version comment in js-api.js updated to match. Cards still supplying 0.0.3 keep working and get the "update your API version" snackbar.

How Has This Been Tested?

Manually, in the reviewer WebView, using the reproduction from the issue:

const jsApiContract = { version: "0.0.4", developer: "test@test.com" };
const api = new AnkiDroidJS(jsApiContract);
api.ankiGetDeckName().then(r => console.log(typeof r, r));
api.ankiGetNextTime1().then(r => console.log(typeof r, r));

Before: string {"success" : true, "value": "…"}. After: object {success: true, value: "…"}, matching ankiIsDisplayingAnswer and the rest.

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[Copilot]

Pull request overview

This PR updates the AnkiDroid JavaScript API so ankiGetNextTime1-4 and ankiGetDeckName resolve to parsed JavaScript objects (consistent with other JS API methods) rather than returning raw JSON strings, and bumps the declared JS API version accordingly.

Changes:

• Bump CURRENT_JS_API_VERSION from 0.0.3 to 0.0.4.
• Remove the JS-side special-casing that returned raw response.text() for nextTime* and deckName, so responses are parsed via JSON.parse() like other endpoints.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidJsAPIConstants.kt	Bumps the current JS API version to 0.0.4.
AnkiDroid/src/main/assets/scripts/js-api.js	Removes endpoint-specific raw string returns and updates the version header comment.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[krmanik]

The js addons files need to be removed, because new js addons for whole ecosystem is under consideration.

[david-allison]

requireApiVersion needs improving before this strategy goes live: it executes a snackbar on each call, and the UX is suboptimal - many users would not be in control of their card templates

[krmanik]

requireApiVersion needs improving before this strategy goes live: it executes a snackbar on each call, and the UX is suboptimal - many users would not be in control of their card templates

Now snackbar call once.