feat: Support nav bar for legacy card browser - #21499
Open
ShaanNarendran wants to merge 1 commit into
Open
Conversation
ShaanNarendran
added
the
GSoC
ShaanNarendran
force-pushed
the
legacy-browser-bottom-nav
branch
from
August 14, 2026 18:18
f7e6f2a to
a2d37b6
Compare
Member
|
API 33 emulator (a2d37b6) 
|
david-allison
added
the
Needs Author Reply
Contributor
Author
ah it wasn't clashing for me, I can bring it down |
Member
|
Maintain a proper spacing between status bar and toolbar |
sanjaysargam
requested changes
Aug 15, 2026
| private fun withBottomNavigationEnabled(action: () -> Unit) { | ||
| private fun withBottomNavigationEnabled(action: () -> Unit) = withBooleanPreference(R.string.dev_bottom_nav_key, true, action) | ||
|
|
||
| private fun withBooleanPreference( |
Member
There was a problem hiding this comment.
I'd extract this helper function to a shared location so that other test utilities can use this if similar patterns exists
Member
There was a problem hiding this comment.
Can you add a comment why this layout exists and when it's used, for future maintainers
Something like :
<!--
Legacy card browser layout for embedded mode (e.g., bottom nav).
Includes the toolbar within the fragment since the host doesn't provide one.
Used when: dev_card_browser_search_view=false AND host is not CardBrowser activity.
-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The PR is to allow the nav bar to work with the legacy/current card browser.
Fixes
Approach
We use a new layout that takes the current card browser toolbar from the card browser activity and adds that layout under the card browser fragment instead so the nav bar is compatible with it. Adding the existing toolbar directly would result in overlapping toolbars so making a new layout seemed to be the best option.
How Has This Been Tested?
Tested on emulator.
Checklist
Please, go through these checks before submitting the PR.