fix(navigation-drawer): fix edge to edge truncation - #21530
Open
david-allison wants to merge 3 commits into
Open
fix(navigation-drawer): fix edge to edge truncation#21530david-allison wants to merge 3 commits into
david-allison wants to merge 3 commits into
Conversation
Portrait and landscape with an open drawer. Assisted-by: Claude Fable 5
Add insets on the left/right. The width of the drawer in the usable space should be unchanged, so use `nav_drawer_width`. We do this as we can't set the max width of the drawer. Fixes 21527 Assisted-by: Claude Fable 5
`include_navigation_drawer.xml` set the width. Assisted-by: Claude Fable 5
Contributor
|
Snapshot diff report vs
All 2 changed screenshotsNavigationDrawerScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Fable 5
Fixes
NavigationDrawerActivity#21527Approach
Apply insets on the edge nearest to the screen
How Has This Been Tested?
API 37;
API 30 & API 29
Learning (optional, can help others)
I'm unhappy with the white on white in the status bar, but I deem this to be 'Won't Fix' - it's been like this for a long time and @ShaanNarendran is working on removing the drawer.
Checklist