refactor: prep for making MANAGE_EXTERNAL_STORAGE optional - #21540
Open
david-allison wants to merge 2 commits into
Open
refactor: prep for making MANAGE_EXTERNAL_STORAGE optional#21540david-allison wants to merge 2 commits into
MANAGE_EXTERNAL_STORAGE optional#21540david-allison wants to merge 2 commits into
Conversation
A `full` build using app-private storage will no longer require `MANAGE_EXTERNAL_STORAGE` permissions (skipping a check checking device capabilities. No difference on a `play` variant. Prep for 13574 Part of 21046: 'Skip' will select app-private storage, and this check is what keeps the permission screen closed afterwards. Co-authored-by: Fandroid745 <dhanush41230@gmail.com> Assisted-by: Claude Fable 5
For future: "Skip" on the permission screen will need the app private directory. Prep for 13574 Split from 21046 Assisted-by: Claude Fable 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Fable 5
Fixes
Approach
See the commits
getDefaultAnkiDroidDirectoryfullto work better with an app-private folder.How Has This Been Tested?
Both are technically non-functional at this point:
Checklist