feat[Multimedia]: Edge to edge support - #21544
Open
criticalAY wants to merge 2 commits into
Open
Conversation
The activity insets its `AppBarLayout` directly, so the bar's background spans the status bar while its content clears it. The insets below the app bar are applied in `MultimediaFragment`, the base class of the only three fragments the activity hosts. They share a shape: a card filling the screen above an `action_done` button, so the button takes the corner clearance as the bottom-most touch target. `setTransparentStatusBar` is replaced rather than kept alongside `enableEdgeToEdge`. Unlike the screens ported so far, the app bar here is the theme's surface colour rather than a saturated one, so the status bar icons follow the user's theme as they did before. Assisted-by: Claude Opus 5
Hosts `AudioRecordingFragment`: the activity renders nothing without a fragment name extra, which is why it was skipped in `AllActivitiesScreenshotTest`. That skip is replaced by an entry in the `handled` set, so the screen is captured once, here. Assisted-by: Claude Opus 5
criticalAY
force-pushed
the
edge-to-edge-multimedia
branch
from
August 16, 2026 21:17
b508e55 to
151ab6b
Compare
Contributor
|
Snapshot diff report vs
All 3 changed screenshotsMultimediaScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5
Purpose / Description
Port MultiediaActivity to support edge to edge
Fixes
MultimediaActivity#21512Approach
See commits
How Has This Been Tested?
API 36 and API 28:
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.