feat[AccountActivity]: Edge to edge support - #21546
Open
criticalAY wants to merge 2 commits into
Open
Conversation
Contributor
|
Snapshot diff report vs
All 4 changed screenshotsAccountActivityScreenshotTest
|
Both fragments own their toolbar and content, so each insets its own root The toolbar is wrapped in a container rather than padded directly, since its `minHeight` would absorb the padding and the bar would lose height. `fitsSystemWindows` is removed from both roots: it handles neither side insets nor rounded display corners. The app bar is the theme's surface colour rather than a saturated one, so the status bar icons follow the user's theme, as the inherited `setTransparentStatusBar` already did. Assisted-by: Claude Opus 5
Assisted-by: Claude Opus 5
criticalAY
force-pushed
the
edge-to-edge-account
branch
from
August 18, 2026 11:25
e810d73 to
2a4de7b
Compare
lukstbit
approved these changes
Aug 18, 2026
| enableEdgeToEdge( | ||
| statusBarStyle = | ||
| SystemBarStyle.auto(Color.TRANSPARENT, Color.TRANSPARENT) { | ||
| Themes.currentTheme is NightTheme |
Member
There was a problem hiding this comment.
Not that important but there's a property for this already: Themes.isNightTheme.
lukstbit
added
Needs Second Approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5
Purpose / Description
Blocked by fix: host the screen in AccountActivity #21545Port AccountActivity to support edge to edge
Fixes
AccountActivity#21513Approach
See commits
How Has This Been Tested?
API 36 and API 28:
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.