Fix and Improve keyring implementation #799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitpokhrel
requested changes
Mar 24, 2025
| @@ -18,26 +20,28 @@ require ( | |||
| github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d | |||
| github.com/mitchellh/go-homedir v1.1.0 | |||
| github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c | |||
| github.com/rivo/tview v0.0.0-20240406141410-79d4cc321256 | |||
| github.com/rivo/tview v0.0.0-20241103174730-c76f7879f592 | |||
There was a problem hiding this comment.
Not sure why we need to update all these deps. Can we only update libs related to this pr? Upgrading libs like tview could have unintended issues and requires proper testing.
There was a problem hiding this comment.
I am not a go developer so I don't know why all of these got updated. I only initialised the repo locally for testing.
I understand the concern and will push a new commit to address this
| secret, _ := keyring.Get("jira-cli", config.Login) | ||
| config.APIToken = secret | ||
|
|
||
| // Only try keyring if explicitly enabled in config |
There was a problem hiding this comment.
Can you pls help understand why we want to have it explicitly enabled?
There was a problem hiding this comment.
I didn't want to break anything as I wasn't sure what was the intended default behaviour. I can make it always check if you'd like?
anthonyrisinger
added a commit
to anthonyrisinger/...
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: