Allow to pass an existing request object in constructor#442
Open
ofabel wants to merge 1 commit intoankitpokhrel:mainfrom
Open
Allow to pass an existing request object in constructor#442ofabel wants to merge 1 commit intoankitpokhrel:mainfrom
ofabel wants to merge 1 commit intoankitpokhrel:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=========================================
Coverage 99.60% 99.60%
Complexity 362 362
=========================================
Files 20 20
Lines 1007 1008 +1
=========================================
+ Hits 1003 1004 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation always creates the HTTP request from the superglobals:
But this is not always possible (e.g. when using RoadRunner). It's also an issue in combination with other frameworks (see #440).
With this pull request, users can pass their own Symfony HTTP request object in the constructor - if necessary.
Of course one could also extend the
Requestclass and do the same. But this would also require extending theServerclass.