Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-version: ['8.1', '8.2', '8.3']
php-version: ['8.1', '8.2', '8.3', '8.4']
composer-flags: ["--prefer-lowest --prefer-stable", ""]
fail-fast: false
services:
Expand Down Expand Up @@ -71,4 +71,4 @@ jobs:
files: coverage.clover
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
if: matrix.php-version == '8.3'
if: matrix.php-version == '8.4'
4 changes: 2 additions & 2 deletions src/Cache/FileStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class FileStore extends AbstractCache
* @param string|null $cacheDir
* @param string|null $cacheFile
*/
public function __construct(string $cacheDir = null, string $cacheFile = null)
public function __construct(?string $cacheDir = null, ?string $cacheFile = null)
{
$cacheDir = $cacheDir ?? Config::get('file.dir');
$cacheFile = $cacheFile ?? Config::get('file.name');
Expand Down Expand Up @@ -134,7 +134,7 @@ public function get(string $key, bool $withExpired = false)
*
* @return mixed
*/
protected function lock(string $path, int $type = LOCK_SH, callable $cb = null, $fopenType = FILE::READ_BINARY)
protected function lock(string $path, int $type = LOCK_SH, ?callable $cb = null, $fopenType = FILE::READ_BINARY)
{
$out = false;
$handle = @fopen($path, $fopenType);
Expand Down
2 changes: 1 addition & 1 deletion src/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static function set($config = null, bool $force = false)
*
* @return mixed
*/
public static function get(string $key = null)
public static function get(?string $key = null)
{
self::set();

Expand Down
4 changes: 2 additions & 2 deletions src/File.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class File
* @param string|null $name
* @param Cacheable|null $cache
*/
public function __construct(string $name = null, Cacheable $cache = null)
public function __construct(?string $name = null, ?Cacheable $cache = null)
{
$this->name = $name;
$this->cache = $cache;
Expand All @@ -74,7 +74,7 @@ public function __construct(string $name = null, Cacheable $cache = null)
*
* @return File
*/
public function setMeta(int $offset, int $fileSize, string $filePath, string $location = null): self
public function setMeta(int $offset, int $fileSize, string $filePath, ?string $location = null): self
{
$this->offset = $offset;
$this->fileSize = $fileSize;
Expand Down
2 changes: 1 addition & 1 deletion src/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public function send($content, int $status = HttpResponse::HTTP_OK, array $heade
*/
public function download(
$file,
string $name = null,
?string $name = null,
array $headers = [],
string $disposition = ResponseHeaderBag::DISPOSITION_ATTACHMENT
): BinaryFileResponse {
Expand Down
2 changes: 1 addition & 1 deletion src/Tus/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function __construct(string $baseUri, array $options = [])
*
* @return Client
*/
public function file(string $file, string $name = null): self
public function file(string $file, ?string $name = null): self
{
$this->filePath = $file;

Expand Down
Loading