Update download_audio.py for Windows#10
Open
fjiang9 wants to merge 1 commit intoankitshah009:masterfrom
Open
Conversation
This update make it works on Windows as well. And it can delete the video and complete audio after the segment is saved, which may save the storage space in your computer.
ankitshah009
requested changes
Jul 3, 2017
Owner
ankitshah009
left a comment
ankitshah009
left a comment
There was a problem hiding this comment.
Please review the file changes as we are currently supporting Linux based distributions. We could place an additional file - download_audio_for_windows.py as per multiple user's requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update make it works on Windows as well. And it can delete the video and complete audio after the segment is saved, which may save the storage space in your computer.