Skip to content

Support autorepeat #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
take-cheeze wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support autorepeat #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions xkbcat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ int main(int argc, char * argv[]) {
{ // Register to receive XInput events
Window root = DefaultRootWindow(disp);
XIEventMask m;
m.deviceid = XIAllMasterDevices;
m.deviceid = XIAllDevices;

@take-cheeze take-cheeze Jan 19, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XI_KeyPress won't be capturable with master devices only

m.mask_len = XIMaskLen(XI_LASTEVENT);
m.mask = calloc(m.mask_len, sizeof(char));
// Raw key presses correspond to physical key-presses, without
// processing steps such as auto-repeat.
XISetMask(m.mask, XI_RawKeyPress);
XISetMask(m.mask, XI_KeyPress);
if (printKeyUps) XISetMask(m.mask, XI_RawKeyRelease);
XISelectEvents(disp, root, &m, 1 /*number of masks*/);
XSync(disp, false);
Expand Down Expand Up @@ -117,7 +117,7 @@ int main(int argc, char * argv[]) {
if (cookie->type == GenericEvent
&& cookie->extension == xiOpcode) {
if (cookie->evtype == XI_RawKeyRelease
|| cookie->evtype == XI_RawKeyPress) {
|| cookie->evtype == XI_KeyPress) {
XIRawEvent *ev = cookie->data;

// Ask X what it calls that key; skip if unknown.
Expand All @@ -142,9 +142,17 @@ int main(int argc, char * argv[]) {
char *str = XKeysymToString(s);
if (NULL == str) continue;

if (cookie->evtype == XI_RawKeyRelease && ev->deviceid != ev->sourceid) continue;

@take-cheeze take-cheeze Jan 19, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate key event would be sent so filtering with deviceid and sourceid


// Output line
if (printKeyUps) printf("%s",
cookie->evtype == XI_RawKeyPress ? "+" : "-");
if (printKeyUps) {
if (cookie->evtype == XI_KeyPress) {
XIDeviceEvent* dev_ev = cookie->data;
printf("%s", (dev_ev->flags & XIKeyRepeat) ? "=" : "+");

@take-cheeze take-cheeze Jan 19, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to output of xinput --test-xi2 --root , XIDeviceEvent was the correct type to handle XI_KeyPress

} else {
printf("-");
}
}
printf("%s\n", str);
fflush(stdout);
}
Expand Down