fix(tui): preserve exit epilogue during scoped shutdown#31805
Open
tobwen wants to merge 1 commit into
Open
Conversation
tobwen
force-pushed
the
fix/tui-exit-epilogue
branch
from
2eddbad to
e077cfc
Compare
Snapshot exit output before scoped cleanup clears session state. Keep title cleanup guarded and cover app.exit with a lifecycle test.
tobwen
force-pushed
the
fix/tui-exit-epilogue
branch
from
e077cfc to
7aebeed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31803
Type of change
What does this PR do?
Fixes a TUI exit bug where scoped cleanup cleared the session epilogue before it was printed.
The fix snapshots the epilogue and exit reason before cleanup, then prints from that snapshot after shutdown.
It also keeps terminal title cleanup outside the renderer destroy guard.
How did you verify your code works?
bun test ./test/app-lifecycle.test.tsx ./test/util/renderer.test.tsbun typecheckbun run build --single --skip-installScreenshots / recordings
Checklist