Select: add showSelectionIndicator option#1192
Open
leonid-shutov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1193
Summary
Add a
showSelectionIndicatorboolean option toSelectRenderablethat controls whether the▶glyph is rendered next to the currently selected item.API
Default:
true(no behaviour change for existing consumers).When set to
false, the indicator glyph and its 2-column gutter are both removed, giving item text two extra columns of horizontal space.Screenshots
Incidental cleanup
Two refactors that aren't part of the feature but were needed to keep the render loop coherent once the configurable indicator was introduced: