Skip to content

fix: resolve code quality issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve code quality issues #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions results/aHR0cHM6Ly9iZXRhLmdvdXYuZnIv/20210425_233709/lhr.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@
--report-text-color: var(--color-gray-100);
--snippet-color: var(--color-cyan-500);
--topbar-background-color: var(--color-gray);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);

/* SVGs */
--plugin-icon-url: var(--plugin-icon-url-dark);
Expand Down Expand Up @@ -2824,7 +2824,7 @@
// Always elide hexadecimal hash
name = name.replace(/([a-f0-9]{7})[a-f0-9]{13}[a-f0-9]*/g, `$1${ELLIPSIS}`);
// Also elide other hash-like mixed-case strings
name = name.replace(/([a-zA-Z0-9-_]{9})(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])[a-zA-Z0-9-_]{10,}/g,
name = name.replace(/([\w-]{9})(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[\w-]{10,}/g,
`$1${ELLIPSIS}`);
// Also elide long number sequences
name = name.replace(/(\d{3})\d{6,}/g, `$1${ELLIPSIS}`);
Expand Down
14 changes: 8 additions & 6 deletions results/aHR0cHM6Ly9iZXRhLmdvdXYuZnIv/20210428_213635/lhr.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@
--report-text-color: var(--color-gray-100);
--snippet-color: var(--color-cyan-500);
--topbar-background-color: var(--color-gray);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);

/* SVGs */
--plugin-icon-url: var(--plugin-icon-url-dark);
Expand Down Expand Up @@ -2824,7 +2824,7 @@
// Always elide hexadecimal hash
name = name.replace(/([a-f0-9]{7})[a-f0-9]{13}[a-f0-9]*/g, `$1${ELLIPSIS}`);
// Also elide other hash-like mixed-case strings
name = name.replace(/([a-zA-Z0-9-_]{9})(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])[a-zA-Z0-9-_]{10,}/g,
name = name.replace(/([a-zA-Z\d-_]{9})(?=.*[a-z])(?=.*[A-Z])(?=.*\d)[a-zA-Z\d-_]{10,}/g,
`$1${ELLIPSIS}`);
// Also elide long number sequences
name = name.replace(/(\d{3})\d{6,}/g, `$1${ELLIPSIS}`);
Expand Down Expand Up @@ -3733,7 +3733,8 @@
displayedPath = parsed.file === '/' ? parsed.origin : parsed.file;
displayedHost = parsed.file === '/' || parsed.hostname === '' ? '' : `(${parsed.hostname})`;
title = url;
} catch (e) {
} catch (e) { // eslint-disable-line no-unused-vars
/* URL parsing may fail for non-standard URLs; fallback to raw string */
displayedPath = url;
}

Expand Down Expand Up @@ -3763,7 +3764,7 @@
let url;
try {
url = new URL(details.url);
} catch (_) {}
} catch (_) { /* Invalid URL; falls through to text rendering below */ }

Check warning on line 3767 in results/aHR0cHM6Ly9iZXRhLmdvdXYuZnIv/20210428_213635/lhr.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 


See more on https://sonarcloud.io/project/issues?id=ansforge_dashlord&issues=AZ4G2fET0UeFthJ8uCgr&open=AZ4G2fET0UeFthJ8uCgr&pullRequest=1

if (!url || !allowedProtocols.includes(url.protocol)) {
// Fall back to just the link text if invalid or protocol not allowed.
Expand Down Expand Up @@ -7534,6 +7535,7 @@
try {
formatter = new Intl.DateTimeFormat(this._numberDateLocale, options);
} catch (err) {
console.warn('Could not format date, falling back to UTC:', err);
options.timeZone = 'UTC';
formatter = new Intl.DateTimeFormat(this._numberDateLocale, options);
}
Expand Down