Produce valid config.json, fix trailing command after grpc_tls #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes trailing comma after `grpc_tls` in addresses configuration block.
The trailing comma makes the generated JSON invalid and breaks tools like `jq`; currently the template produces:
```
"addresses": {
"dns": "0.0.0.0",
"http": "0.0.0.0",
"https": "0.0.0.0",
"grpc": "0.0.0.0",
"grpc_tls": "0.0.0.0",
},
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes trailing comma after
grpc_tlsin addresses configuration block.The trailing comma makes the generated JSON invalid and breaks tools like
jq; currently the template produces:grpc_tlsshould not have trailing comma.Fixes #572
ISSUE TYPE
COMPONENT NAME
Config template.