Support templating in ansible_user

[jovial]

SUMMARY

Before this change it is not possible to use templating for the ansible_user e.g:

  ansible_user: "{{ some_variable }}"

The error you see looks like:

Unexpected remote arg: }}@10.0.0.97:/tmp/ansible.lq33g1agrally-results/\nrsync error: syntax or usage error (code 1) at main.c(1354) [sender=3.1.3]\n"

The module arguments look like:

        "module_args": {                                                                                                                                                      
            "_local_rsync_password": null,                                                                                                                                    
            "_local_rsync_path": "rsync",                                                                                                                                     
            "_substitute_controller": false,                                                                                                                                  
            "archive": false,                                                                                                                                                 
            "checksum": false,                                                                                                                                                
            "compress": true,                                                                                                                                                 
            "copy_links": false,                                                                                                                                              
            "delay_updates": true,                                                                                                                                            
            "delete": false,                                                                                                                                                  
            "dest": "/stack/tempest-artifacts",                                                                                                                               
            "dest_port": null,                                                                                                                                                
            "dirs": false,                                                                                                                                                    
            "existing_only": false,                                                                                                                                           
            "group": null,                                                                                                                                                    
            "link_dest": null,                                                                                                                                                
            "links": null,                                                                                                                                                    
            "mode": "pull",                                                                                                                                                   
            "owner": null,                                                                                                                                                    
            "partial": false,                                                                                                                                                 
            "perms": null,                                                                                                                                                    
            "private_key": null,                                                                                                                                              
            "recursive": true,                                                                                                                                                
            "rsync_opts": [],                                                                                                                                                 
            "rsync_path": null,                                                                                                                                               
            "rsync_timeout": 0,                                                                                                                                               
            "set_remote_user": true,                                                                                                                                          
            "src": "{{ kayobe_ansible_user }}@10.0.0.97:/tmp/ansible.lq33g1agrally-results/",                                                                                 
            "ssh_args": "-C -o ControlMaster=auto -o ControlPersist=60s",                                                                                                     
            "ssh_connection_multiplexing": false,                                                                                                                             
            "times": null,                                                                                                                                                    
            "verify_host": false                                                                                                                                              
        } 

In this case I'm using:

ansible_user: "{{ kayobe_ansible_user }}"

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

synchronize

ADDITIONAL INFORMATION

[bcoca]

the vars were always the wrong thing to get, the correct info should be from the connection itself using get_option

[jovial]

Seems like a good suggestion. Would we need to parse ssh_args to get the user? Or is that exposed as an option? Do we need to consider other connection plugins other than ssh?

[maxamillion]

ping @bcoca @jovial - this conversation is a bit stale :)

[bcoca]

all connections at this point should be relying on get_option some older ones might still be using play_context.<data> but this is incorrect as it does not always reflect changes do to modifiers in the task (mostly loops). In no case should you be using variables directly.