synchronize: use _find_needle instead

[mnaser]

SUMMARY

It's not possible to use files from a sub role, this patch fixes this.

Fixes #381

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

synchornize

ADDITIONAL INFORMATION

See #381

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d98fe75b98a74d8e88bac6026a45b37e

❌ ansible-changelog-fragment FAILURE in 15s
✔️ ansible-test-sanity-docker-devel SUCCESS in 6m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 6m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 09s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 6m 54s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 11s
✔️ ansible-test-units-posix-python39 SUCCESS in 4m 42s
✔️ ansible-test-units-posix-python310 SUCCESS in 5m 47s
✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 6m 32s

[gtirloni]

@tima coud you review this PR?

[jillr]

@mnaser Apologies in the delay getting this reviewed. Would you be willing to add a changelog fragment to this PR?

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0653511774424920a0ac9c263d688e70

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 6m 58s

[mnaser]

@Akasurde thanks for adding the release note, I'm not sure why jobs are failing, could we help land this?

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ad00ea40bceb4f08b780ea9cba70d10d

✔️ ansible-galaxy-importer SUCCESS in 2m 36s
✔️ build-ansible-collection SUCCESS in 5m 39s

[mnaser]

@Akasurde hmm, i see the failures seem to be related to the second time around copy, do you know why/how i can dig into this?

[Akasurde]

@mnaser I think this -

ansible.posix/tests/integration/targets/synchronize/tasks/main.yml

Line 56 in 1994b2c

- name: Test that the file is not copied a second time

test is failing. If you see the logs it is trying to find

looking for "'/root/ansible_collections/ansible/posix/tests/output/.tmp/output_dir/foo.txt'" at "/root/ansible_collections/ansible/posix/tests/output/.tmp/integration/synchronize-pq5aaj8p-ÅÑŚÌβŁÈ/tests/integration/targets/synchronize/files/'/root/ansible_collections/ansible/posix/tests/output/.tmp/output_dir/foo.txt'"

See that the destination is resolved wrong.