Open
Conversation
for more information, see https://pre-commit.ci
added 2 commits
March 6, 2025 09:57
…l and protocol_options handling fixed, tests added
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added objects support for cisco.asa.asa_acls protocol, source and destination parameters
ISSUE TYPE
COMPONENT NAME
cisco.asa.asa_acls
ADDITIONAL INFORMATION
Based on this PR #178 with slight modifications
I would love to have support for objects in ACEs since I use them a lot to keep my ACLs self-documented. Implementing object groups was definitely a milestone, but they lack some features like ranges and FQDN support. I believe I'm not the only one who wants objects to be supported as there were attempts to implement this before.