fix: cannot access local variable 'identifier' where it is not associ… #10030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated with a value
ansibullbot
added
bug
felixfontein
added
check-before-release
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks!
| @@ -890,6 +890,7 @@ def lxc_present(self, vmid, hostname, node, update, force): | |||
| self.module.exit_json( | |||
| changed=False, vmid=vmid, msg="VM %s already exists." % identifier | |||
| ) | |||
| identifier = self.format_vm_identifier(vmid, lxc["name"]) | |||
There was a problem hiding this comment.
The only path where it isn't defined is in else of the above ifs:
Suggested change
| identifier = self.format_vm_identifier(vmid, lxc["name"]) | |
| else: | |
| identifier = self.format_vm_identifier(vmid, lxc["name"]) |
|
FYI, the proxmox content from this repository is currently being moved to https://github.com/ansible-collections/community.proxmox. Once that repo is ready, you'll have to create a new PR there, as from that point this repo is only accepting bugfixes that have already been merged into the other repo. For now you can use this PR in this repo to continue working on the PR. (The other repo has no CI yet, for example.) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If
community.general.proxmoxis called on an existing lxc container withstate=presentandforce: truethen we take a code path in which a debugging message is printed but the identifier was no defined beforehand, leading to the error "An error occurred: cannot access local variable 'identifier' where it is not associated with a value".ISSUE TYPE
COMPONENT NAME
proxmox