rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10097

kjoyce77 · 2025-05-03T13:08:45Z

SUMMARY

The original author of this module did not include logic for when the project is specified for the acl despite adding the option to the doc. This change adds logic that will post/put the acl to the project path if the project is specified.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rundeck_acl_policy

ADDITIONAL INFORMATION

The second of these steps fail.

- name: Create a system ACL
  community.general.rundeck_acl_policy:
    name: test_acl
    api_version: "{{ rundeck_api_version }}"
    url: "{{ rundeck_url }}"
    token: "{{ rundeck_api_token.stdout_lines[-1] }}"
    state: present
    policy: "{{ system_acl_policy }}"

- name: Create a project ACL
  community.general.rundeck_acl_policy:
    name: test_acl
    api_version: "{{ rundeck_api_version }}"
    url: "{{ rundeck_url }}"
    token: "{{ rundeck_api_token.stdout_lines[-1] }}"
    state: present
    policy: "{{ project_acl_policy }}"
    project: test_project

When running the playbook the second step fails, not because of the absence of test_project, but because the acl is seen as invalid since the module is posting to the system endpoint.

# before
(general) nimbus@odin:~/dev/ansible_collections/community/general$ ansible-test integration unsupported/rundeck --docker
PLAY [testhost] ****************************************************************

TASK [Gathering Facts] *********************************************************
ok: [testhost]

TASK [rundeck : Generate a Rundeck API Token] **********************************
FAILED - RETRYING: [testhost]: Generate a Rundeck API Token (3 retries left).
changed: [testhost]

TASK [rundeck : Create a Rundeck project] **************************************
changed: [testhost]

TASK [rundeck : Create a system ACL] *******************************************
changed: [testhost]

TASK [rundeck : Create a project ACL] ******************************************
fatal: [testhost]: FAILED! => {"changed": false, "msg": "Unable to validate acl test_acl. Please ensure it is a valid ACL"}

# after
(general) nimbus@odin:~/dev/ansible_collections/community/general$ ansible-test integration unsupported/rundeck --docker
TASK [rundeck : Create a Rundeck project] **************************************
changed: [testhost]

TASK [rundeck : Create a system ACL] *******************************************
changed: [testhost]

TASK [rundeck : Create a project ACL] ******************************************
changed: [testhost]

TASK [rundeck : Retrieve ACLs] *************************************************
ok: [testhost] => (item=system/acl/test_acl.aclpolicy)
ok: [testhost] => (item=project/test_project/acl/test_acl.aclpolicy)

TASK [rundeck : Assert ACL content is correct] *********************************
ok: [testhost] => {
    "changed": false,
    "msg": "All assertions passed"

ansibullbot · 2025-05-03T13:10:15Z

cc @nerzhul
click here for bot help

felixfontein

Thanks for your contribution! I've added a first comment.

changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml

…oint.yml Co-authored-by: Felix Fontein <[email protected]>

felixfontein · 2025-05-15T05:28:10Z

If nobody objects, I'll merge this in a few days.

russoz

LGTM

patchback · 2025-05-17T06:01:35Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/ff0ed6f91205403f21cd50fe86fdbae0f34221e8/pr-10097

Backported as #10150

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…oint (#10097) * Fix project acls are put/posted to the wrong endpoint * Add changelog fragment. * Fix 2.7 sanity errors in github * Fix fragment extension and use 2.7 syntax in test * Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml Co-authored-by: Felix Fontein <[email protected]> * Fix pep8 formatting * Add licensing to unit test --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ff0ed6f)

patchback · 2025-05-17T06:01:43Z

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/ff0ed6f91205403f21cd50fe86fdbae0f34221e8/pr-10097

Backported as #10151

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein · 2025-05-17T06:01:47Z

@kjoyce77 thanks for your contribution!
@russoz thanks for reviewing!

…oint (#10097) * Fix project acls are put/posted to the wrong endpoint * Add changelog fragment. * Fix 2.7 sanity errors in github * Fix fragment extension and use 2.7 syntax in test * Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml Co-authored-by: Felix Fontein <[email protected]> * Fix pep8 formatting * Add licensing to unit test --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ff0ed6f)

…ct acls are put/posted to the wrong endpoint (#10150) rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint (#10097) * Fix project acls are put/posted to the wrong endpoint * Add changelog fragment. * Fix 2.7 sanity errors in github * Fix fragment extension and use 2.7 syntax in test * Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml * Fix pep8 formatting * Add licensing to unit test --------- (cherry picked from commit ff0ed6f) Co-authored-by: kjoyce77 <[email protected]> Co-authored-by: Felix Fontein <[email protected]>

…ect acls are put/posted to the wrong endpoint (#10151) rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint (#10097) * Fix project acls are put/posted to the wrong endpoint * Add changelog fragment. * Fix 2.7 sanity errors in github * Fix fragment extension and use 2.7 syntax in test * Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml * Fix pep8 formatting * Add licensing to unit test --------- (cherry picked from commit ff0ed6f) Co-authored-by: kjoyce77 <[email protected]> Co-authored-by: Felix Fontein <[email protected]>

…oint (ansible-collections#10097) * Fix project acls are put/posted to the wrong endpoint * Add changelog fragment. * Fix 2.7 sanity errors in github * Fix fragment extension and use 2.7 syntax in test * Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml Co-authored-by: Felix Fontein <[email protected]> * Fix pep8 formatting * Add licensing to unit test --------- Co-authored-by: Felix Fontein <[email protected]>

Fix project acls are put/posted to the wrong endpoint

9b3258d

ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit labels May 3, 2025

This comment was marked as outdated.

Sign in to view

kjoyce77 added 2 commits May 3, 2025 15:31

Add changelog fragment.

9858fa4

Fix 2.7 sanity errors in github

ecd48a7

ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label May 3, 2025

This comment was marked as outdated.

Sign in to view

ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label May 3, 2025

Fix fragment extension and use 2.7 syntax in test

f3ec7f2

This comment was marked as outdated.

Sign in to view

ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label May 4, 2025

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels May 4, 2025

felixfontein reviewed May 4, 2025

View reviewed changes

changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml Outdated Show resolved Hide resolved

Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endp…

91f36ba

…oint.yml Co-authored-by: Felix Fontein <[email protected]>

ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI labels May 5, 2025

kjoyce77 added 2 commits May 7, 2025 23:27

Fix pep8 formatting

8c620b3

Add licensing to unit test

d906197

ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label May 7, 2025

kjoyce77 marked this pull request as ready for review May 8, 2025 02:43

ansibullbot removed the WIP Work in progress label May 8, 2025

russoz changed the title ~~Fix project acls are put/posted to the wrong endpoint~~ rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint May 17, 2025

ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 17, 2025

russoz approved these changes May 17, 2025

View reviewed changes

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 17, 2025

felixfontein merged commit ff0ed6f into ansible-collections:main May 17, 2025
135 checks passed

patchback bot mentioned this pull request May 17, 2025

[PR #10097/ff0ed6f9 backport][stable-9] rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10150

Merged

patchback bot mentioned this pull request May 17, 2025

[PR #10097/ff0ed6f9 backport][stable-10] rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10151

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10097

rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10097

Uh oh!

kjoyce77 commented May 3, 2025

Uh oh!

ansibullbot commented May 3, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

felixfontein left a comment

Uh oh!

Uh oh!

felixfontein commented May 15, 2025

Uh oh!

russoz left a comment

Uh oh!

Uh oh!

patchback bot commented May 17, 2025 •

edited

Loading

Uh oh!

patchback bot commented May 17, 2025 •

edited

Loading

Uh oh!

felixfontein commented May 17, 2025

Uh oh!

Uh oh!

rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10097

rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint #10097

Uh oh!

Conversation

kjoyce77 commented May 3, 2025

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Uh oh!

ansibullbot commented May 3, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

felixfontein left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

felixfontein commented May 15, 2025

Uh oh!

russoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patchback bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-9: 💚 backport PR created

Uh oh!

patchback bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-10: 💚 backport PR created

Uh oh!

felixfontein commented May 17, 2025

Uh oh!

Uh oh!

patchback bot commented May 17, 2025 •

edited

Loading

patchback bot commented May 17, 2025 •

edited

Loading