Skip to content

ini_file: fix unmatched whitespace before comment #10102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2025
Merged

ini_file: fix unmatched whitespace before comment #10102

merged 3 commits into from
May 10, 2025

Conversation

sibebleuze
Copy link
Contributor

@sibebleuze sibebleuze commented May 4, 2025 •
edited
Loading

SUMMARY

Expanded the regular expression for inactive ("commented out") options to also match when the comment symbol (# or ;) is preceded by whitespace.

Fixes #8539

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ini_file

ADDITIONAL INFORMATION

Example input

[section1]
  # option1 = value1

Example task using ini_file module

- name: Edit option 1 in section 1 to have value = value2
  ini_file:
    path: /path/to/file
    modify_inactive_option: true
    section: "section1"
    option: "option1"
    value: "value2"

Output before this change

[section1]
option1 = value2
  # option1 = value1

Output after this change

[section1]
option1 = value2

@ansibullbot
Copy link
Collaborator

cc @jpmens @noseka1
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels May 4, 2025
@sibebleuze sibebleuze changed the title [WIP] ini_file: fix unmatched whitespace before comment ini_file: fix unmatched whitespace before comment May 4, 2025
@sibebleuze sibebleuze marked this pull request as ready for review May 4, 2025 18:33
@ansibullbot ansibullbot removed the WIP Work in progress label May 4, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels May 4, 2025
felixfontein
felixfontein reviewed May 4, 2025
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! A first comment below.

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR feature This issue/PR relates to a feature request and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 4, 2025
@felixfontein felixfontein removed the bug This issue/PR relates to a bug label May 5, 2025
russoz
russoz approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 43eb342 into ansible-collections:main May 10, 2025
135 checks passed
@patchback Patchback
Copy link

patchback bot commented May 10, 2025 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/43eb342b180e550ea1742da88377e46e4e94c170/pr-10102

Backported as #10116

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 10, 2025
patchback bot pushed a commit that referenced this pull request May 10, 2025
@sibebleuze @felixfontein @patchback
ini_file: fix unmatched whitespace before comment (#10102)
3398f36 
* ini_file: fix unmatched whitespace before comment

* Add changelog fragment

* Update changelog fragment: bugfixes to minor_changes

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: sibebleuze <>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 43eb342)
@patchback patchback bot mentioned this pull request May 10, 2025
Merged
@felixfontein
Copy link
Collaborator

@sibebleuze thanks for your contribution!
@russoz thanks for reviewing!

felixfontein added a commit that referenced this pull request May 10, 2025
@patchback @sibebleuze @felixfontein
[PR #10102/43eb342b backport][stable-10] ini_file: fix unmatched whit…
d557997 
…espace before comment (#10116)

ini_file: fix unmatched whitespace before comment (#10102)

* ini_file: fix unmatched whitespace before comment

* Add changelog fragment

* Update changelog fragment: bugfixes to minor_changes



---------

Co-authored-by: sibebleuze <>

(cherry picked from commit 43eb342)

Co-authored-by: Sibe Bleuzé <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ini_file: allow whitespace at start of commented option
4 participants
@sibebleuze @ansibullbot @felixfontein @russoz