Skip to content

ipa: add environment fallback support for validate_certs #10753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ipa: add environment fallback support for validate_certs #10753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a87d0e
Add environment fallback support for validate_certs
zjpeterson Aug 28, 2025
e9ffedd
add changelog fragment
zjpeterson Aug 28, 2025
3809ac9
fix pr number
zjpeterson Aug 28, 2025
3bce377
Apply suggestions from code review.
felixfontein Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/10753-ipa-validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- ipa_* modules - support environment fallback for ``validate_certs`` parameter (https://github.com/ansible-collections/community.general/pull/10753).
2 changes: 2 additions & 0 deletions plugins/doc_fragments/ipa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ class ModuleDocFragment(object):
- This only applies if O(ipa_prot) is V(https).
- If set to V(false), the SSL certificates are not validated.
- This should only set to V(false) used on personally controlled sites using self-signed certificates.
- If the value is not specified in the task, the value of environment variable E(IPA_VALIDATE_CERTS) is used instead.
If both the environment variable E(IPA_VALIDATE_CERTS) and the value are not specified in the task, then default value is used.
Comment on lines +65 to +66
Copy link
Collaborator

@felixfontein felixfontein Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If the value is not specified in the task, the value of environment variable E(IPA_VALIDATE_CERTS) is used instead.
If both the environment variable E(IPA_VALIDATE_CERTS) and the value are not specified in the task, then default value is used.
- If the value is not specified in the task, the value of environment variable E(ANSIBLE_IPA_VALIDATE_CERTS) is used instead.
If both the environment variable E(ANSIBLE_IPA_VALIDATE_CERTS) and the value are not specified in the task, then default value is used.

type: bool
default: true
ipa_timeout:
Expand Down
2 changes: 1 addition & 1 deletion plugins/module_utils/ipa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,5 +211,5 @@ def ipa_argument_spec():
ipa_user=dict(type='str', default='admin', fallback=(env_fallback, ['IPA_USER'])),
ipa_pass=dict(type='str', no_log=True, fallback=(env_fallback, ['IPA_PASS'])),
ipa_timeout=dict(type='int', default=10, fallback=(env_fallback, ['IPA_TIMEOUT'])),
validate_certs=dict(type='bool', default=True),
validate_certs=dict(type='bool', default=True, fallback=(env_fallback, ['IPA_VALIDATE_CERTS'])),
Copy link
Collaborator

@felixfontein felixfontein Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
validate_certs=dict(type='bool', default=True, fallback=(env_fallback, ['IPA_VALIDATE_CERTS'])),
validate_certs=dict(type='bool', default=True, fallback=(env_fallback, ['ANSIBLE_IPA_VALIDATE_CERTS'])),

)