Skip to content

[PR #11114/a8378a4e backport][stable-12] nmcli idempotency connection check #11437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixfontein merged 1 commit into from
Jan 20, 2026
Merged

[PR #11114/a8378a4e backport][stable-12] nmcli idempotency connection check #11437

felixfontein merged 1 commit into from
Jan 20, 2026
+65 −18

Conversation

@patchback
Copy link

@patchback patchback bot commented Jan 20, 2026

This is a backport of PR #11114 as merged into main (a8378a4).

SUMMARY

This PR will update the module to be idempotent by:

  • Checking the current connection status before executing commands.
  • Avoiding unnecessary commands when the desired state has already been achieved.
  • Returning changed=False when no action is required.
  • Properly managing check mode for up and down states.
  • The module will no longer generate changes when an interface is already in the desired state, so that respect Ansible's idempotence principle.

Ref : #9897

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • nmcli

@saibug @patchback
nmcli idempotency connection check (#11114)
d1b401b 
* nmcli idempotency connection check

* Changelog fragment and ruff reformat

* Fix : change error handling

* Remove odd conditions

* Refactor nmcli: fix error handling and remove redundant logic

* Fix code format

* Fix error message to handle

(cherry picked from commit a8378a4)
@patchback patchback bot mentioned this pull request Jan 20, 2026
Merged
@ansibullbot
Copy link
Collaborator

ansibullbot commented Jan 20, 2026

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 20, 2026
@felixfontein felixfontein merged commit 68bd8ba into stable-12 Jan 20, 2026
125 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-12/a8378a4eb0d31cd0dd197e8266451e30c6a68ea7/pr-11114 branch January 20, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ansibullbot @felixfontein @saibug