Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Proxmox HAS_PROXMOXER check into module_utils. #4030

Merged
merged 4 commits into from
Jan 16, 2022
Merged

Move Proxmox HAS_PROXMOXER check into module_utils. #4030

merged 4 commits into from
Jan 16, 2022

Conversation

reitermarkus
Copy link
Contributor

SUMMARY

Simplify code by moving Proxmox HAS_PROXMOXER check into module_utils.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

proxmox

ADDITIONAL INFORMATION

Extracted from #4027.

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @joshainglis @karmab @paginabianca @tleguern
click here for bot help

@ansibullbot ansibullbot added cloud module module module_utils module_utils needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI new_contributor Help guide this first time contributor plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jan 12, 2022
Thulium-Drake
Thulium-Drake approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@Thulium-Drake Thulium-Drake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your work!

@ansibullbot ansibullbot added tests tests unit tests/unit labels Jan 12, 2022
@reitermarkus reitermarkus force-pushed the proxmox-proxmoxer branch 2 times, most recently from 4ba03d0 to 1fd89bb Compare January 12, 2022 12:28
@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Jan 12, 2022
@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 12, 2022
@reitermarkus
Copy link
Contributor Author

Should be good to go now.

@felixfontein felixfontein merged commit 761fbe4 into ansible-collections:main Jan 16, 2022
@patchback
Copy link

patchback bot commented Jan 16, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/761fbe4fa359d7ea692d82ef4cb7c4521c60888a/pr-4030

Backported as #4046

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 16, 2022
@reitermarkus @patchback
Move Proxmox HAS_PROXMOXER check into module_utils. (#4030)
e83a245 
* Move Proxmox `HAS_PROXMOXER` check into `module_utils`.

* Fix tests.

* Fix typo.

* Update changelog entry.

(cherry picked from commit 761fbe4)
@patchback patchback bot mentioned this pull request Jan 16, 2022
Merged
@felixfontein
Copy link
Collaborator

@reitermarkus thanks for implementing this!
@Thulium-Drake thanks for reviewing!

@felixfontein felixfontein mentioned this pull request Jan 16, 2022
Merged
felixfontein pushed a commit that referenced this pull request Jan 16, 2022
@patchback @reitermarkus
Move Proxmox HAS_PROXMOXER check into module_utils. (#4030) (#4046)
9e6df4f 
* Move Proxmox `HAS_PROXMOXER` check into `module_utils`.

* Fix tests.

* Fix typo.

* Update changelog entry.

(cherry picked from commit 761fbe4)

Co-authored-by: Markus Reiter <[email protected]>
@reitermarkus reitermarkus deleted the proxmox-proxmoxer branch January 19, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@Thulium-Drake Thulium-Drake Thulium-Drake approved these changes

Assignees
No one assigned
Labels
cloud module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reitermarkus @ansibullbot @felixfontein @Thulium-Drake