Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for setting mtu on ipip and gre interfaces in nmcli.py #9604

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Update changelogs/fragments/9604-mtu-allow-ipipgre-interfaces.yml

2848030
Select commit
Loading
Failed to load commit list.
Open

fix for setting mtu on ipip and gre interfaces in nmcli.py #9604

Update changelogs/fragments/9604-mtu-allow-ipipgre-interfaces.yml
2848030
Select commit
Loading
Failed to load commit list.
Azure Pipelines / CI failed Jan 23, 2025 in 2m 56s

Build #20250123.25 had test failures

13 errors / 2 warnings

Details

Tests

  • Failed: 26 (1.28%)
  • Passed: 1,991 (97.74%)
  • Other: 20 (0.98%)
  • Total: 2,037

Annotations

Check failure on line 754 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L754 

Bash exited with code '1'.

Check failure on line 751 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L751 

Bash exited with code '1'.

Check failure on line 932 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L932 

Bash exited with code '1'.

Check failure on line 905 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L905 

Bash exited with code '1'.

Check failure on line 1 in test_ipip_connection_unchanged[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_ipip_connection_unchanged[patch_ansible_module0] 

assert not True
Raw output 
mocked_ipip_connection_unchanged = None
capfd = <_pytest.capture.CaptureFixture object at 0x71621cec9a58>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_IPIP, indirect=['patch_ansible_module'])
    def test_ipip_connection_unchanged(mocked_ipip_connection_unchanged, capfd):
        """
        Test : IPIP connection unchanged
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        out, err = capfd.readouterr()
        results = json.loads(out)
        assert not results.get('failed')
>       assert not results['changed']
E       assert not True

tests/unit/plugins/modules/test_nmcli.py:2911: AssertionError

Check failure on line 1 in test_gre_connection_unchanged[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_gre_connection_unchanged[patch_ansible_module0] 

assert not True
Raw output 
mocked_gre_connection_unchanged = None
capfd = <_pytest.capture.CaptureFixture object at 0x71621ced07b8>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_GRE, indirect=['patch_ansible_module'])
    def test_gre_connection_unchanged(mocked_gre_connection_unchanged, capfd):
        """
        Test : GRE connection unchanged
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        out, err = capfd.readouterr()
        results = json.loads(out)
        assert not results.get('failed')
>       assert not results['changed']
E       assert not True

tests/unit/plugins/modules/test_nmcli.py:3083: AssertionError

Check failure on line 1 in test_gre_connection_unchanged[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_gre_connection_unchanged[patch_ansible_module0] 

assert not True
Raw output 
mocked_gre_connection_unchanged = None
capfd = <_pytest.capture.CaptureFixture object at 0x7be73c19f0d0>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_GRE, indirect=['patch_ansible_module'])
    def test_gre_connection_unchanged(mocked_gre_connection_unchanged, capfd):
        """
        Test : GRE connection unchanged
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        out, err = capfd.readouterr()
        results = json.loads(out)
        assert not results.get('failed')
>       assert not results['changed']
E       assert not True

tests/unit/plugins/modules/test_nmcli.py:3083: AssertionError

Check failure on line 1 in test_ipip_connection_unchanged[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_ipip_connection_unchanged[patch_ansible_module0] 

assert not True
Raw output 
mocked_ipip_connection_unchanged = None
capfd = <_pytest.capture.CaptureFixture object at 0x7be73c213f90>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_IPIP, indirect=['patch_ansible_module'])
    def test_ipip_connection_unchanged(mocked_ipip_connection_unchanged, capfd):
        """
        Test : IPIP connection unchanged
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        out, err = capfd.readouterr()
        results = json.loads(out)
        assert not results.get('failed')
>       assert not results['changed']
E       assert not True

tests/unit/plugins/modules/test_nmcli.py:2911: AssertionError
View more details on Azure Pipelines