Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9853/4727fb77 backport][stable-10] cmd_runner tests: fix reliance on unspecified behavior #9857

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 9, 2025

This is a backport of PR #9853 as merged into main (4727fb7).

SUMMARY

Modules exiting by exception resulting in crashing the module before the data tagging PR. Unfortunately the tests relied on the old behavior.

Modules that support ansible-core before data tagging should never crash intentionally, and if they do, should not rely on anything except that the task fails.

Extracted from #9833.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

cmd_runner integration tests

Fix reliance on unspecified behavior.

(cherry picked from commit 4727fb7)
@ansibullbot ansibullbot added backport integration tests/integration new_contributor Help guide this first time contributor tests tests labels Mar 9, 2025
@felixfontein felixfontein merged commit 5f1f76b into stable-10 Mar 9, 2025
141 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-10/4727fb77b367a3c79dd549cbfd0803ad0b64098b/pr-9853 branch March 9, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integration tests/integration new_contributor Help guide this first time contributor tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants