Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payload to match Rocket Chat 7.4.1 API #9882

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
deprecated_features:
- >
RocketChat module - attribute ``option_is_pre740`` has been added to match the old payload. The argument default value could be set to false in a few months and then,
removed in a future release when Rocket Chat 7.4.0 is considered as a minimum version to be used (https://github.com/ansible-collections/community.general/pull/9882).
17 changes: 13 additions & 4 deletions plugins/modules/rocketchat.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@
elements: dict
description:
- Define a list of attachments.
option_is_pre740:
description:
- If V(true), the payload matches Rocket Chat prior to 7.4.0 format
type: bool
default: true
"""

EXAMPLES = r"""
Expand Down Expand Up @@ -165,7 +170,7 @@
ROCKETCHAT_INCOMING_WEBHOOK = '%s://%s/hooks/%s'


def build_payload_for_rocketchat(module, text, channel, username, icon_url, icon_emoji, link_names, color, attachments):
def build_payload_for_rocketchat(module, text, channel, username, icon_url, icon_emoji, link_names, color, attachments, option_is_pre740):
payload = {}
if color == "normal" and text is not None:
payload = dict(text=text)
Expand Down Expand Up @@ -195,7 +200,9 @@ def build_payload_for_rocketchat(module, text, channel, username, icon_url, icon
attachment['fallback'] = attachment['text']
payload['attachments'].append(attachment)

payload = "payload=" + module.jsonify(payload)
payload = module.jsonify(payload)
if option_is_pre740:
payload = "payload=" + module.jsonify(payload)
return payload


Expand Down Expand Up @@ -225,7 +232,8 @@ def main():
link_names=dict(type='int', default=1, choices=[0, 1]),
validate_certs=dict(default=True, type='bool'),
color=dict(type='str', default='normal', choices=['normal', 'good', 'warning', 'danger']),
attachments=dict(type='list', elements='dict', required=False)
attachments=dict(type='list', elements='dict', required=False),
option_is_pre740=dict(default=True, type='bool')
)
)

Expand All @@ -240,8 +248,9 @@ def main():
link_names = module.params['link_names']
color = module.params['color']
attachments = module.params['attachments']
option_is_pre740 = module.params['option_is_pre740']

payload = build_payload_for_rocketchat(module, text, channel, username, icon_url, icon_emoji, link_names, color, attachments)
payload = build_payload_for_rocketchat(module, text, channel, username, icon_url, icon_emoji, link_names, color, attachments, option_is_pre740)
do_notify_rocketchat(module, domain, token, protocol, payload)

module.exit_json(msg="OK")
Expand Down