Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payload to match Rocket Chat 7.4.1 API #9882

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix payload to match Rocket Chat 7.4.1 API #9882

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d9a6ef3
Fix payload to match Rocket Chat 7.4 API
broferek Mar 14, 2025
bdab72a
Add a fallback to send payload argument in case the user still intera…
broferek Mar 14, 2025
5e27b45
Fix sanity checks
broferek Mar 14, 2025
a1e8a46
Add changelog fragment of PR #9882
Mar 18, 2025
ee2e635
Add argument option_is_pre740 to keep backward compatibility of the p…
Mar 18, 2025
3a32e46
Add new argument doc
Mar 18, 2025
539207d
Rename new parameter, add missing pieces of information in parameter doc
Mar 19, 2025
33825b7
Use appropriate change label and fix change description. Description …
Mar 19, 2025
b620315
Fix missing punctuation in the new parameter doc block
Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/modules/rocketchat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def build_payload_for_rocketchat(module, text, channel, username, icon_url, icon
attachment['fallback'] = attachment['text']
payload['attachments'].append(attachment)

payload = "payload=" + module.jsonify(payload)
payload = module.jsonify(payload)
return payload


Expand All @@ -208,7 +208,9 @@ def do_notify_rocketchat(module, domain, token, protocol, payload):

response, info = fetch_url(module, rocketchat_incoming_webhook, data=payload)
if info['status'] != 200:
module.fail_json(msg="failed to send message, return status=%s" % str(info['status']))
response, info = fetch_url(module, rocketchat_incoming_webhook, data="payload=" + payload)
if info['status'] != 200:
module.fail_json(msg="failed to send message, return status=%s" % str(info['status']))


def main():
Expand Down