DRS Override - add state argument

[Rogacz]

SUMMARY

Added new state attribute with absent, disabled, enabled options to support missing functionality.
You can now remove existing DRS override or set DRS Override to disabled, which is different from manual.

Also added improvements:

• Add name, uuid, moid, options to find VM in same standard as used in other modules, with optional folder, datacenter, use_instance_uuid arguments
• Added alias vm_name to name argument to keep backward compatibility
• Actually support check_mode as it was ignored previously
• Properly handle editing and removal of existing DRS override entry
• Expand description

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_drs_override

ADDITIONAL INFORMATION

At work, I need to create and remove DRS override for VMs, so here is an improved version of the module.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/150ee2f3859d4fa59078586284c5d5d6

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection FAILURE in 4m 39s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/78c940fd75514529bfbf7fcfa2990b83

❌ ansible-tox-linters FAILURE in 4m 51s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ba428005e6ac4464a6b65320231cfc47

✔️ ansible-tox-linters SUCCESS in 4m 55s
✔️ build-ansible-collection SUCCESS in 7m 45s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 21m 37s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 18m 38s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 53m 50s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 1h 06m 41s
✔️ ansible-galaxy-importer SUCCESS in 4m 17s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/382a2a5a543b41f98da0cb7b8871f46b

✔️ ansible-tox-linters SUCCESS in 5m 45s
✔️ build-ansible-collection SUCCESS in 7m 32s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 15m 32s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 45s (non-voting)

[ihumster]

I am a little embarrassed by the presence of absent without present - I would add for compatibility and logic present with the same logic as enabled

[Rogacz]

I can just rename enabled to present. Options would be present/absent/disabled
My thought process was that both disabled and enabled are present, and didn't want to separate it to state=absent/present and enabled=true/false options.
But I understand it breaks a convention.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/089645577b5446c7b60f852a33001a7e

✔️ ansible-tox-linters SUCCESS in 5m 40s
✔️ build-ansible-collection SUCCESS in 7m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 17m 32s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 14m 38s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 11m 13s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 48m 35s
✔️ ansible-galaxy-importer SUCCESS in 3m 40s (non-voting)

[Rogacz]

I've noticed that tests were skipped

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d47950839c3343f08956639001a63f9a

✔️ ansible-tox-linters SUCCESS in 5m 39s
✔️ build-ansible-collection SUCCESS in 7m 32s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 17m 05s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 32s (non-voting)

[Rogacz]

It fails on something unrelated to this PR.
On content library tasks: The provided storage backing rw_datastore for library cfea863b-8db1-4b5f-a54d-8cfe64b9c9ed is inaccessible

[Rogacz]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/49f2bec902ce4e0ca4a90b425dd144e9

✔️ ansible-tox-linters SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 8m 37s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 16m 19s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 FAILURE in 13m 02s
✔️ ansible-galaxy-importer SUCCESS in 3m 46s (non-voting)

[mariolenz]

I'm sorry, but my priority ATM is to make the collection work with the upcoming ansible-core 2.19 release (#2388 and #2391).

It turns out that this is harder than I originally expected. Please bear wit me 🙏