Skip to content

[DNM] Test with ansible-core 2.19 #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Apr 20, 2025

Depends-On: ansible/ansible-zuul-jobs#1905

SUMMARY

Testing with ansible-core 2.19

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_vswitch

ADDITIONAL INFORMATION

#2250

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

mariolenz commented Apr 21, 2025

For the record:

2025-04-20 19:46:39.770057 | controller | [ERROR]: Task failed: Module failed: [' File "", line 198, in _run_module_as_main\n', ' File "", line 88, in _run_code\n', ' File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/cloud/common/plugins/module_utils/turbo/server.py", line 413, in \n', ' File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/cloud/common/plugins/module_utils/turbo/server.py", line 390, in start\n', ' File "/usr/lib64/python3.11/asyncio/base_events.py", line 604, in run_forever\n self._run_once()\n', ' File "/usr/lib64/python3.11/asyncio/base_events.py", line 1909, in _run_once\n handle._run()\n', ' File "/usr/lib64/python3.11/asyncio/events.py", line 80, in _run\n self._context.run(self._callback, *self._args)\n', ' File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/cloud/common/plugins/module_utils/turbo/server.py", line 352, in handle\n', ' File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/cloud/common/plugins/module_utils/turbo/server.py", line 305, in run_as_module\n', 'Traceback (most recent call last):\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/cloud/common/plugins/module_utils/turbo/server.py", line 201, in run\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/vmware/vmware_rest/plugins/modules/vcenter_datacenter_info.py", line 220, in main\n module = AnsibleModule(\n ^^^^^^^^^^^^^^\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible_collections/cloud/common/plugins/module_utils/turbo/module.py", line 112, in init\n ansible.module_utils.basic.AnsibleModule.init(\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible/module_utils/basic.py", line 421, in init\n self._load_params()\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible/module_utils/basic.py", line 1216, in _load_params\n self.params = _load_params()\n ^^^^^^^^^^^^^^\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible/module_utils/basic.py", line 328, in _load_params\n _ANSIBLE_ARGS, _ANSIBLE_PROFILE = _debugging.load_params()\n ^^^^^^^^^^^^^^^^^^^^^^^^\n File "/tmp/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload_sijk5778/ansible_vmware.vmware_rest.vcenter_datacenter_info_payload.zip/ansible/module_utils/_internal/_debugging.py", line 25, in load_params\n if sys.stdin.isatty():\n ^^^^^^^^^^^^^^^^\nAttributeError: 'FakeStdin' object has no attribute 'isatty'\n']

@mariolenz
Copy link
Collaborator Author

I thought that one or more of the integration tests I've re-added in #2373 might be responsible for the CI failure. But it doesn't look like it: #2385

I think I'll have to work on a fix or a least a work-around. That is

  1. substitute the vmware.vmware_rest modules used in the CI
  2. fix this in vmware.vmware_rest
  3. fix this in cloud.common (Possible problem with ansible-core 2.19? cloud.common#165)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant