Skip to content

Change datastore check to check if the destination_datastore is the "primary" datastore in vmware_vmotion.py #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ITJoeSchmo wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Change datastore check to check if the destination_datastore is the "primary" datastore in vmware_vmotion.py #2537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/modules/vmware_vmotion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def __init__(self, module):
dest_host_name,
"', '".join([ds.name for ds in self.host_object.datastore])))

if self.vm.runtime.host.name == dest_host_name and dest_datastore in [ds.name for ds in self.vm.datastore]:
if self.vm.runtime.host.name == dest_host_name and vm_ds_name == self.datastore_object.name:
change_required = False

elif self.host_object and self.datastore_cluster_object:
Expand Down Expand Up @@ -335,7 +335,7 @@ def __init__(self, module):
self.cluster_object.datastore])))

if self.vm.runtime.host.name in [host.name for host in self.cluster_hosts] and \
dest_datastore in [ds.name for ds in self.vm.datastore]:
vm_ds_name == self.datastore_object.name:
change_required = False

elif self.cluster_object and self.datastore_cluster_object:
Expand Down Expand Up @@ -370,7 +370,7 @@ def __init__(self, module):

elif (self.datastore_object and self.host_object is None) or (
self.datastore_object and self.cluster_object is None):
if self.datastore_object in self.vm.datastore:
if vm_ds_name == self.datastore_object.name:
# VM is already located on same datastore
change_required = False

Expand Down