Skip to content

inventory plugin: adding the instance hostname field as inventory hostname #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

inventory plugin: adding the instance hostname field as inventory hostname #438

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44e4d4b
feat: add hostname instance field as an inventory hostname
Jun 24, 2021
69cb57d
Merge branch 'ansible-collections:master' into master
DeLoWaN Jul 1, 2021
ef0720c
Merge branch 'master' into master
DeLoWaN Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/inventory/gcp_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@
hostnames:
description: A list of options that describe the ordering for which
hostnames should be assigned. Currently supported hostnames are
'public_ip', 'private_ip', 'name' or 'labels.vm_name'.
'public_ip', 'private_ip', 'name', 'labels.vm_name' or 'hostname'.
As 'hostname' may not be defined,
it will fallback on 'name'.
default: ['public_ip', 'private_ip', 'name']
type: list
auth_kind:
Expand Down Expand Up @@ -238,6 +240,9 @@ def hostname(self):
name = self._get_privateip()
elif order == "name":
name = self.json[u"name"]
elif order == "hostname":
# If hostname is not defined, then fallback on name
name = self.json[u"hostname"] if "hostname" in self.json else self.json[u"name"]
else:
raise AnsibleParserError("%s is not a valid hostname precedent" % order)

Expand Down