Add function to validate cidr superset #562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
approved these changes
Mar 4, 2023
Collaborator
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
This looks good to me, and I ran integration tests locally so safe to merge
Is there a way we can / should test this in an automated fashion? Wanted to ask in case we can verify this behavior via CI in the future before I merge.
|
|
||
| if request_vals['ipCidrRange']: | ||
| try: | ||
| result_superset = cidr_superset(request_vals['ipCidrRange'], response_vals['ipCidrRange']) |
Collaborator
There was a problem hiding this comment.
nit: i'd suggest something like result_is_superset to indicate that the value is a boolean (It's hard to infer the type of result_superset).
Author
There was a problem hiding this comment.
Thanks @toumorokoshi for the suggestion, I changed it to result_is_superset.
toumorokoshi
requested changes
Mar 4, 2023
Collaborator
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
actually looks like lint failed. Can you fix your styling and ensure integration tests pass before I merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
GCP doesn't allow to shrink of the CIDR of a subnet but the original module doesn't throw an error if the requested new CIDR is not a superset of the original IP range. This PR suggests adding a condition check and error out for this scenario.
Fixes #563
ISSUE TYPE
COMPONENT NAME
This PR suggests adding a condition check to error out the above-mentioned scenario, by comparing the requested new CIDR is not a superset of the original IP range of the subnet.
ADDITIONAL INFORMATION
GCP API will throw an error on this case which the current ansible module doesn't handle. Refer the API guide for details. https://cloud.google.com/compute/docs/reference/rest/v1/subnetworks/insert