Cloud Build v2 #729
Open
Cloud Build v2 #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set your logging to -vvv or greater, logs should appear in whatever logging facility you have configured in the control node, e.g. journald for localhost
As generated from the code gen tool
Collaborator
Author
|
@SirGitsalot PTAL, I am not sure how the integration test would work at all for this one, I could just remove the integration test dir altogether |
Collaborator
Author
|
Also not sure how to fix the sanity test issues here... the items pointed out are not secrets, but references to secret manager resources, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding support for Cloud Build v2 connections and repositories. No integration tests because this would require creating oauth tokens on gitlab/github and then storing them in the CI which is probably a lot more complicated. I tested it with my own personal Github and Gitlab accounts, and it seems to work.
Additionally, I added a small "debug" function to gcp_utils which I am referencing from the code for general tracing
ISSUE TYPE
COMPONENT NAME
gcp_cloudbuildv2_connection
gcp_cloudbuildv2_repository