[Role][1625]simple_role_to_get_job_status #2386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMarcel99
requested review from
Rohitcodes28,
fernandofloresg,
mayankmani-sde,
rexemin,
richp405 and
surendrababuravella
richp405
previously approved these changes
Oct 28, 2025
richp405
previously approved these changes
Oct 30, 2025
fernandofloresg
requested changes
Nov 7, 2025
Collaborator
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
requested few changs
| if "AC" in status_raw: | ||
| # the job is active | ||
| ret_code["msg"] = None | ||
| ret_code["msg_code"] = None |
Collaborator
There was a problem hiding this comment.
if this is not set, will it still be returned as None or not returned at all ?
Collaborator
There was a problem hiding this comment.
Maybe it would make sense to set them as none at the start of the function
Collaborator
Author
There was a problem hiding this comment.
It returns as None, but right better to be safe
Co-authored-by: Fernando Flores <[email protected]>
Co-authored-by: Fernando Flores <[email protected]>
Collaborator
Author
|
richp405
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Create a role that execute zos_job_query to parsing the response to return job_status and if is running or not as boolean value. Fixes #1625
ISSUE TYPE
COMPONENT NAME
Role that get first value of zos_job_query expecting to be the job_id set by the user.
Delete unnecessary parsing on zos_job_query that remove the current estatus of the job.
Also adding test method for roles on pytest.