Open
Conversation
lmshubhashri
approved these changes
Mar 26, 2026
stair-lm
requested changes
Mar 26, 2026
Collaborator
stair-lm
left a comment
There was a problem hiding this comment.
There are other license references that need to be updated.
For example:
Lines 170 to 172 in 3505f52
logicmonitor/plugins/modules/lm_alert_rule.py
Lines 3 to 5 in 3505f52
Collaborator
|
@lm-madhvi Since the license is changing, I'd recommend a major version change (i.e., Line 3 in 3505f52 The major revbump signals to consumers that there's a breaking|incompatible change. In this case, it's not a backwards-incompatible API but a license switcheroo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.