Conversation
gotmax23
approved these changes
May 6, 2023
Collaborator
gotmax23
left a comment
gotmax23
left a comment
There was a problem hiding this comment.
Ack, but please use a more descriptive commit subject than Refactor when squash merging or just push the two commits separately.
Collaborator
|
Thanks for working on this! |
Collaborator
Author
|
@gotmax23 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains all changes from #65 that do not change the output.
The idea is that the code changes in #65 get simpler so it's easier to rebase after reformatting the code base. The only other open PR, #75, has almost no code changes, so it can be easily rebased.