Add pre-commit.com hooks for lint-collection-docs#231
Draft
gotmax23 wants to merge 2 commits intoansible-community:mainfrom
Draft
Add pre-commit.com hooks for lint-collection-docs#231gotmax23 wants to merge 2 commits intoansible-community:mainfrom
gotmax23 wants to merge 2 commits intoansible-community:mainfrom
Conversation
Collaborator
felixfontein
left a comment
There was a problem hiding this comment.
I'm not sure this is a good idea.
- Who installs ansible-core?
- Who installs the required collections (for docs fragments, references, ...)?
Co-authored-by: Felix Fontein <felix@fontein.de>
ssbarnea
approved these changes
Aug 19, 2024
Member
I like the idea but there are some problems with using with pre-commit:
|
felixfontein
requested changes
Aug 19, 2024
Collaborator
felixfontein
left a comment
There was a problem hiding this comment.
Leaving a negative review so this won't get merged prematurely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.