fix #239 , use python-style templating instead of Jinja in the plugins login_cmd_template #240
Conversation
danielpodwysocki
had a problem deploying
to
ack
GitHub Actions
Failure
|
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
|
I tested by editing this change into my venv locally and can now log in correctly to ec2 instances by calling |
danielpodwysocki
force-pushed
the
main
branch
from
55ae73e to
9279b58
Compare
danielpodwysocki
had a problem deploying
to
ack
GitHub Actions
Failure
danielpodwysocki
changed the title
|
It affects users on all plugins - updated the PR to address each. |
git clean -xdf
tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec
cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3
rm -rf ../python*-molecule-plugins*23.5.3*.*
See ansible-community#155
See ansible-community#237
See ansible-community#240
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
Any news on this? |
git clean -xdf
tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec
cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3
rm -rf ../python*-molecule-plugins*23.5.3*.*
See ansible-community#155
See ansible-community#237
See ansible-community#240
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
Any news on this PR? This bug breaks some of the plugin functionality quite badly. |
|
Can also confirm, that this fixes the issue. |
|
@danielpodwysocki Please add a label to the PR. Would recommend to use 'patch' here. Otherwise following check is failing to success 'ack / ack / ack (pull_request_target) '. |
@ekin-oener-provsn I miss permissions to do that here, I could only create the PR but seems I cannot edit labels. It will need to be someone with enough access to this repo. |
|
Confirm. Fixes the same issue for me. |
|
Fixes the issue on Arch Linux. Seems good to merge. |
|
Bump... the fix seems good, we just need a maintainer to add the label to the PR as the submitter asserts they lack permission to edit the labels. |
|
Bump. Please merge this, the bug is breaking stuff. |
|
Can confirm the PR fixed the issue locally for me, is it possible for it to be merged? |
|
please please please get this merged, as we are re-writing all our ansible roles and this would help so much |
+1 please approve this. |
|
@audgirka are you able to progress this PR please? |
|
@apatard Have had a quick look at the failed builds and can see that |
I found time to fix that the other day but didn't find enough time to clean, push and create a PR. I hope I'll do it this week |
|
PR opened, and looks like the CI is green, so only a reviewer is needed to get it merged. This should unblock this PR |
|
Any news here? This is a rather annoying bug to work around and feels like something we should be addressing in weeks, not months? |
once the CI is fixed, this PR will be merged. As long as my PR about fixing the CI is not merged (in this form or any other form), I fear it's stuck :( |
|
Right, looks like my PR has been merged (big thanks to @ssbarnea). Once this PR is rebased, it'll be ready to be merged I guess. |
…nja in all drivers login_cmd_template
This file assumes Jinja templating for the port parameter and passes a Jinja-style "{{ port }}".
https://github.com/ansible/molecule/blob/main/src/molecule/command/login.py#L105
When it reaches molecule, it is subsituted in this file and is done by python calling `.format()` on the string.
That causes it to not render correctly and gives users issues running
molecule login.
ref: ansible-community#239
Fixed all affected plugins.
danielpodwysocki
force-pushed
the
main
branch
from
e26e3cd to
a552f4c
Compare
Awesome - I've rebased off of |
|
Any chance to finally release? 🙏 |
This file assumes Jinja templating for the port parameter and passes a Jinja-style "{{ port }}".
https://github.com/ansible/molecule/blob/main/src/molecule/command/login.py#L105
When it reaches molecule, it is subsituted in this file and is done by python calling
.format()on the string. That causes it to not render correctly and gives users issues running molecule login.ref: #239