Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: hide service account content from the logs for gce driver #302

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,15 @@
- "Dump instance config"

- name: Wait for SSH
no_log: "{{ molecule_no_log }}" # GCE modules leaks GCP_SERVICE_ACCOUNT_CONTENTS value in returned values from module, which contains private key
ansible.builtin.wait_for:
port: 22
host: "{{ item.networkInterfaces.0.accessConfigs.0.natIP if molecule_yml.driver.external_access else item.networkInterfaces.0.networkIP }}"
search_regex: SSH
delay: 10
loop: "{{ server.results }}"
loop_control:
label: "{{ item.name }}"
register: waitfor
until: waitfor.failed == false
retries: 6
Expand Down
1 change: 1 addition & 0 deletions test/gce/scenarios/linux/tasks/create_linux_instance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- Dump instance config

- name: Wait for SSH
no_log: "{{ molecule_no_log }}"
ansible.builtin.wait_for:
port: 22
host: "{{ item.networkInterfaces.0.accessConfigs.0.natIP if molecule_yml.driver.external_access else item.networkInterfaces.0.networkIP }}"
Expand Down
Loading