fix: remove trailing dot causing invalid YAML in goss vars template#93
Open
aaronk1 wants to merge 1 commit intoansible-lockdown:develfrom
Open
fix: remove trailing dot causing invalid YAML in goss vars template#93aaronk1 wants to merge 1 commit intoansible-lockdown:develfrom
aaronk1 wants to merge 1 commit intoansible-lockdown:develfrom
Conversation
'rhel10cis_rule_1_2_1_5: {{ rhel10cis_rule_1_2_1_5 }}. ## New' renders
as 'rhel10cis_rule_1_2_1_5: true.' which is not valid YAML. Goss will
fail to parse the vars file if run_audit is enabled. Also converted
'## New' to a valid YAML inline comment '# New'.
Signed-off-by: Aaron Klepinger <aaronk1@users.noreply.github.com>
|
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/ansible_vars_goss.yml.j2contains a trailing dot in a variable reference:The trailing
.produces invalid YAML when the template is rendered. Fix: remove the trailing dot.Signed-off-by: aaronk1 aaronk1@users.noreply.github.com