fix: correct handler name for systemd daemon reload#94
Open
aaronk1 wants to merge 1 commit intoansible-lockdown:develfrom
Open
fix: correct handler name for systemd daemon reload#94aaronk1 wants to merge 1 commit intoansible-lockdown:develfrom
aaronk1 wants to merge 1 commit intoansible-lockdown:develfrom
Conversation
Rule 3.1.3 notified 'Systemd_daemon_reload' (underscore) but the handler in handlers/main.yml is named 'Systemd daemon reload' (spaces). Ansible does exact string matching on handler names, so the handler silently never fired after masking bluetooth.service. Same pattern as the postfix handler fix in ansible-lockdown#47. Signed-off-by: Aaron Klepinger <aaronk1@users.noreply.github.com>
|
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The handler name
Systemd_daemon_reloaduses an underscore which does not match thenotifyreferences in tasks that callSystemd daemon reload(with a space). This causes the handler to never fire.Fix: rename the handler to
Systemd daemon reloadto match all notify references.Signed-off-by: aaronk1 aaronk1@users.noreply.github.com