fix: 🐛 handle 'all' in outbound ports loop in rule rule_4.1.5 and apt/dpkg lock#329
fix: 🐛 handle 'all' in outbound ports loop in rule rule_4.1.5 and apt/dpkg lock#329tmeckel wants to merge 4 commits intoansible-lockdown:develfrom
apt/dpkg lock#329Conversation
apt/dpkg lock
Signed-off-by: Thomas Meckel <tmeckel@users.noreply.github.com>
Add ubtu22cis_apt_lock_timeout variable to configure wait time for apt/dpkg frontend lock to clear before failing package tasks. Defaults to 180 seconds. Signed-off-by: Thomas Meckel <tmeckel@users.noreply.github.com>
Apply the `ubtu22cis_apt_lock_timeout` variable to all libpam package installation tasks to prevent potential lock contention during concurrent package operations. Signed-off-by: Thomas Meckel <tmeckel@users.noreply.github.com>
394df1a to
d50f241
Compare
The ansible.builtin.package module does not support the lock_timeout parameter which is specific to apt. Switch to ansible.builtin.apt to properly utilize the apt lock timeout configuration added for PAM package installations.
|
hi @tmeckel Thank you for the PR, unfortunately they are not passing DCO. While the commits are GPG signed they are not signed-off-by. Many thanks uk-bolly |
@uk-bolly THX for the hint. Just still working on the UBUNTU24-CIS version of the PR ansible-lockdown/UBUNTU24-CIS#137. When I have both in sync I'll sign off all the commits again. I'll keep you posted 👍🏼 |
|
hi @tmeckel Thank you but we seem to still have an issue with the DCO for your commits. Kindest regards uk-bolly |
Please ensure that you have understood contributing guide
Ensure all commits are signed-by and gpg signed
Overall Review of Changes:
tasks/section_4/cis_4.1.x.ymlso the loop in the4.1.5 "Custom ports"task uses an empty list whenubtu22cis_ufw_allow_out_ports == 'all', instead of looping over the raw value.Issue Fixes:
Closes: #328
Closes: #330
Enhancements:
N/A
How has this been tested?:
Local image builder