add_docs: Fix #94 to_text exception (unsupported type <class 'pathlib.PosixPath'>)#96
Open
trinitronx wants to merge 1 commit intoansible-network:masterfrom
Open
Conversation
…<class 'pathlib.PosixPath'>)
Author
|
Note: The All other hooks are passing: $ pre-commit run --all-files
ruff.....................................................................Passed
prettier.................................................................Passed
black....................................................................Passed
Spell check with cspell..................................................Passed
Tabs remover.............................................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
debug statements (python)................................................Passed
fix end of files.........................................................Passed
fix utf-8 byte order marker..............................................Passed
don't commit to branch...................................................Passed
trim trailing whitespace.................................................Passed
codespell................................................................Passed
yamllint.................................................................Passed
darglint.................................................................Passed |
|
Any chance this can be merged soon and a release generated. I'm hitting this when using ansible-core 2.20 and python 3.14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following error1 when running
collection_prep_add_docs -p path/to/a_collection:Footnotes
Note: Ansible core
_AnsibleCollectionFindercode still uses deprecated internal_to_textmethod (as of Ansible2.20.0), which does not handlepathlib.PosixPath. Meanwhile,to_textfromansible.module_utils.common.text.convertersnow does. Therefore, we can convert to text here using the publicto_textimport if available in newer Ansible versions, else fall back to the old import. ↩