-
Notifications
You must be signed in to change notification settings - Fork 61
AAP-62665 - Adding an important section and editing previous doc. #5580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.6
Are you sure you want to change the base?
Conversation
sayjadha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, rest LGTM.
| . Under *Route TLS termination mechanism*, click the drop-down menu and select *Edge* or *Passthrough*. For most instances *Edge* should be selected. | ||
| . Under *Route TLS credential secret*, click the drop-down menu and select a secret from the list. | ||
| . Under *Enable persistence for __/var/lib/projects__ directory* select either true or false by moving the slider. | ||
| . Navigate to *Operators → Installed Operators*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For menu UI labels, consider changing it to menu:View[Operators > Installed Operators].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Kyla, you can use "menu:Operators[Installed Operators]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Select your *{OperatorPlatformNameShort}* deployment. | ||
| . Select the *{ControllerNameStart}* tab. | ||
| . Create or edit an instance: | ||
| .. For new instances, click *Create {ControllerNameStart}*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The steps 'for new instances' and 'for existing instances' seem to be options and the user needs to select one of these. If this is correct, consider changing the sub-numbered list to bulleted list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'd argue here it's an either or option, where order is not significant.
If you used a nested numbered list it means do step a. first then do step b. While an unordered list here dictates the order is not important so choose the most correct option for you
| . In the *Route DNS host* field, enter the common host name the route answers to. | ||
| . In the *Route TLS termination mechanism* list, select *Edge* or *Passthrough*. Edge is recommended for most instances. | ||
| . In the *Route TLS credential secret* list, select a secret. | ||
| . Use the slider to enable or disable persistence for the `/var/lib/projects` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is this a toggle switch or a checkbox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toggle is the most appropriate wording here that will be uniform across OCP docs.
AAP-62665