Skip to content

Corrections to mcp/execution environments#5946

Draft
ianf77 wants to merge 2 commits intoansible:mainfrom
ianf77:AAP-72785
Draft

Corrections to mcp/execution environments#5946
ianf77 wants to merge 2 commits intoansible:mainfrom
ianf77:AAP-72785

Conversation

@ianf77
Copy link
Copy Markdown
Contributor

@ianf77 ianf77 commented Apr 23, 2026

Testathon changes to MCP servers and execution environments.

https://redhat.atlassian.net/browse/AAP-72785

@ianf77 ianf77 added Ready for technical review Content is ready for technical reviews 2.6 Content applies for 2.6 Needs backport to 2.6 Changes still need to be applied to the 2.6 branch labels Apr 23, 2026
@ianf77 ianf77 marked this pull request as draft April 23, 2026 09:42
Testathon changes to MCP servers and execution environments.

https://redhat.atlassian.net/browse/AAP-72785
Corrections

Testathon changes to MCP servers and execution environments.

https://redhat.atlassian.net/browse/AAP-72785
@fistilis
Copy link
Copy Markdown

Hey Ian, thanks for the PR. I reviewed against the feedback from AAP-73188 and the testathon notes — a few items need attention before this can merge.

Regressions introduced by this PR

  1. pyoi typo introduced: In ref-evaluate-mcp-servers.adoc, the change goes from lang: "pypi" to lang: "pyoi" — this introduces the typo into the security best practices section rather than fixing it. The original pyoi typo in the installation method table (in ref-mcp-builder-collection.adoc) also still needs to be corrected to pypi.

  2. mkdir command is still wrong: The fix uses square brackets [defaults,tasks,meta] instead of curly braces {defaults,tasks,meta}, and removes roles/cfn_mcp/ from the path. The correct command should be:

    mkdir -p collections/ansible_collections/myorg/mcp_cfn/roles/cfn_mcp/{defaults,tasks,meta}
    
  3. Version string 1.0.1.9 should be 1.0.19: All version updates use a four-segment version (1.0.1.9) instead of the correct three-segment semver 1.0.19. Affects galaxy.yml, defaults/main.yml, dependency field, and security best practices.

  4. Final tarball reference still says 1.0.0: End of proc-create-custom-mcp-server-role.adoc still has myorg-mcp_cfn-1.0.0.tar.gz — should be 1.0.19 to match.

  5. Mismatched quotes on manifest path: The fix for the concatenated path uses a backtick to open and a single quote to close: `/opt/mcp/mcpservers.json'). Should use matching backticks.

  6. Double backtick still present: install_manager`` task — the errant double backtick from the original is still there.

Still outstanding from AAP-73188

  • "built-in" → "dev preview": Section 6.6 references "built-in Model Context Protocol (MCP)" — should say "dev preview" per product positioning.
  • Invalid lang type downstream failure: Docs say "install manager skips installation" but generate_manifest.yml then fails with 'dict object' has no attribute 'path' (rc=2). Either document this downstream failure or note it as a known limitation.
  • Directory structure shows files no command creates: The structure diagram shows galaxy.yml, README.md, LICENSE, and main.yml files, but no documented command creates them. This is misleading for someone following step-by-step.
  • Role name inconsistency: Role name switches from cfn_mcp to mcp_cfn at step 7, breaking copy-paste flow.
  • AsciiDoc rendering issues: Section 6.7 has "ote" (part of "remote") greyed out; sections 6.8 and 6.11 have +/* characters that should render as bullets.
  • Remote mode wording contradiction: The main text still says "skips installation" right before the new NOTE saying the package is still installed. Suggest rewording the main text itself rather than contradicting it with a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.6 Content applies for 2.6 Needs backport to 2.6 Changes still need to be applied to the 2.6 branch Ready for technical review Content is ready for technical reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants