You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey Ian, thanks for the PR. I reviewed against the feedback from AAP-73188 and the testathon notes — a few items need attention before this can merge.
Regressions introduced by this PR
pyoi typo introduced: In ref-evaluate-mcp-servers.adoc, the change goes from lang: "pypi"tolang: "pyoi" — this introduces the typo into the security best practices section rather than fixing it. The original pyoi typo in the installation method table (in ref-mcp-builder-collection.adoc) also still needs to be corrected to pypi.
mkdir command is still wrong: The fix uses square brackets [defaults,tasks,meta] instead of curly braces {defaults,tasks,meta}, and removes roles/cfn_mcp/ from the path. The correct command should be:
Version string 1.0.1.9 should be 1.0.19: All version updates use a four-segment version (1.0.1.9) instead of the correct three-segment semver 1.0.19. Affects galaxy.yml, defaults/main.yml, dependency field, and security best practices.
Final tarball reference still says 1.0.0: End of proc-create-custom-mcp-server-role.adoc still has myorg-mcp_cfn-1.0.0.tar.gz — should be 1.0.19 to match.
Mismatched quotes on manifest path: The fix for the concatenated path uses a backtick to open and a single quote to close: `/opt/mcp/mcpservers.json'). Should use matching backticks.
Double backtick still present: install_manager`` task — the errant double backtick from the original is still there.
Still outstanding from AAP-73188
"built-in" → "dev preview": Section 6.6 references "built-in Model Context Protocol (MCP)" — should say "dev preview" per product positioning.
Invalid lang type downstream failure: Docs say "install manager skips installation" but generate_manifest.yml then fails with 'dict object' has no attribute 'path' (rc=2). Either document this downstream failure or note it as a known limitation.
Directory structure shows files no command creates: The structure diagram shows galaxy.yml, README.md, LICENSE, and main.yml files, but no documented command creates them. This is misleading for someone following step-by-step.
Role name inconsistency: Role name switches from cfn_mcp to mcp_cfn at step 7, breaking copy-paste flow.
AsciiDoc rendering issues: Section 6.7 has "ote" (part of "remote") greyed out; sections 6.8 and 6.11 have +/* characters that should render as bullets.
Remote mode wording contradiction: The main text still says "skips installation" right before the new NOTE saying the package is still installed. Suggest rewording the main text itself rather than contradicting it with a note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testathon changes to MCP servers and execution environments.
https://redhat.atlassian.net/browse/AAP-72785