Skip to content

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Oct 13, 2025

Jira Issue: https://issues.redhat.com/browse/AAP-54538

Description

Upgrade works now, but old PVC keeps running and taking resources. We want to remove PVC on upgrade/install if it is still present. The logic is duplicated as on the delete phase.

Testing

Steps to test

  1. Pull down the PR
  2. ...
  3. ...

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This PR should be released in 2.4 (cherry-pick should be created)
  • This PR should be released in 2.5 (cherry-pick should be created)
  • This PR should be released in 2.6 (cherry-pick should be created)
  • This code change requires the following considerations before going to production:

Note

Adds an upgrade step to delete the legacy Chatbot PVC before deploying the service.

  • Chatbot role:
    • Upgrade step: In roles/chatbot/tasks/main.yml, include upgrade_chatbot.yml to clean up old PVC before deployment.
    • New task: roles/chatbot/tasks/upgrade_chatbot.yml removes legacy PersistentVolumeClaim ({{ ansible_operator_meta.name }}-chatbot-pvc) in {{ ansible_operator_meta.namespace }} using kubernetes.core.k8s with wait: yes.

Written by Cursor Bugbot for commit 2a6dbfe. This will update automatically on new commits. Configure here.

Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hasys hasys enabled auto-merge (squash) October 13, 2025 15:39
@hasys hasys merged commit 5822444 into main Oct 13, 2025
8 checks passed
@hasys hasys deleted the pvc_auto_remove branch October 13, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants